Will I always be good at singing? I practice a lot too. Just scares me thinking about it?

It really depends.
If your voice breaks then maybe you wont.
If you atrain your voice too much then that could damage you voice box
I regularly sing as well but I haven't experienced any problems.
Just don't strain yourself too much and enjoy it :)